Filter input data by network adapter name for #2 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balupton
approved these changes
Jul 30, 2017
There was a problem hiding this comment.
LGTM. Only change that I would imagine is use of ( and ) for function calls, and use of null instead of undefined. However, they will not prevent the merge.
If any of the maintainers want to do a release, that will be great.
Otherwise, will get to it on my next Bevry maintenance run.
|
Releasing now to v1.3.0 - thank you for the contribution, sorry it took so long to merge. If you want, I can give you push access so you can publish releases without needing me in the future. |
|
Thank you for merging it. I don't need the push access. I think my code needs some reviews after all. 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the long delayed response.
I followed your coding style this time.